✨Async Jobs: add some tests + an internal client #7410
Merged
+492
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
requested review from
GitHK,
matusdrobuliak66 and
pcrespov
as code owners
sanderegg
force-pushed
the
async-jobs-enhancements
branch
from
864fabe to
5b2d357
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7410 +/- ##
==========================================
- Coverage 87.31% 87.14% -0.17%
==========================================
Files 1712 1343 -369
Lines 66430 56101 -10329
Branches 1125 584 -541
==========================================
- Hits 58004 48890 -9114
+ Misses 8106 7024 -1082
+ Partials 320 187 -133
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Cool, thanks a lot for the effort!
Left some suggestions and questions, mainly for my understanding.
services/storage/src/simcore_service_storage/modules/celery/_celery_types.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
packages/service-library/tests/rabbitmq/test_rabbitmq_rpc_interfaces_async_jobs.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
pcrespov
approved these changes
Mar 21, 2025
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Outdated
Show resolved
Hide resolved
|
GitHK
reviewed
Mar 24, 2025
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
GitHK
approved these changes
Mar 24, 2025
packages/service-library/src/servicelib/rabbitmq/rpc_interfaces/async_jobs/async_jobs.py
Show resolved
Hide resolved
bisgaard-itis
approved these changes
Mar 24, 2025
Contributor
bisgaard-itis
left a comment
bisgaard-itis
left a comment
There was a problem hiding this comment.
Thanks a lot for the clarifications and the effort
mrnicegyu11
pushed a commit
to mrnicegyu11/osparc-simcore
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops checklist